Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate docs to readthedocs.org #308

Closed
76 tasks done
JakeGinnivan opened this issue Sep 29, 2015 · 27 comments
Closed
76 tasks done

Migrate docs to readthedocs.org #308

JakeGinnivan opened this issue Sep 29, 2015 · 27 comments
Labels

Comments

@JakeGinnivan
Copy link
Contributor

JakeGinnivan commented Sep 29, 2015

What needs to be done, post here if you are picking up a topic. I will put your name next to the task, please try and submit a pull request soon after so the task does not get blocked. If you cannot complete your task, let me know and I can remove you!

Current docs are at http://docs.shouldly-lib.net/v2.4.0 - some docs are missing, others out of date. Once the section has been created in the new docs, I will delete it out of the current docs site. If you notice I have missed something, yell out!

The docs are in the docs folder in the repository, so just submit a pull request. For new files make sure you update the mkdocs.yml file. https://github.com/shouldly/shouldly/tree/master/docs

Top level is a single markdown file, second level indicates a H2 (or ##) in that file

Equality

  • ShouldBe
    • Object
    • Numeric
    • DateTime(Offset)
    • TimeSpan
    • String (should link to string ShouldBe section)
    • Enumerable (link to ShouldBe in enumerable section)
  • ShouldNotBe
    • Object
    • Numeric
    • DateTime(Offset)
    • TimeSpan
  • ShouldBeTrue/False
  • ShouldBeNull
    • ShouldNotBeNull
  • ShouldBeSameAs
    • ShouldNotBeSameAs
  • ShouldBeOneOf
    • ShouldNotBeOneOf
  • ShouldBeGreater/LessThan
    • ShouldBeGreaterThan
    • ShouldBeLessThan
    • ShouldBeGreaterThanOrEqualTo
    • ShouldBeLessThanOrEqualTo
  • ShouldBeInRange
    • ShouldNotBeInRange
  • ShouldBeOfType
    • ShouldNotBeOfType
  • ShouldBeAssignableTo
    • ShouldNotBeAssignableTo

Strings

All these should show the case sensitivity options.

  • ShouldBe
    • ShouldNotBe
  • ShouldStartWith
    • ShouldNotStartWith
  • ShouldEndWith
    • ShouldNotEndWith
  • ShouldMatch
  • ShouldBeNullOrEmpty
    • ShouldNotBeNullOrEmpty
  • ShouldBeNullOrWhiteSpace
    • ShouldNotBeNullOrWhiteSpace
  • ShouldContain
    • ShouldNotContain
  • ShouldContainWithoutWhitespace

Enumerable

  • ShouldBe (move from equality section)
  • ShouldAllBe
  • ShouldBeEmpty
    • ShouldNotBeEmpty
  • ShouldBeSubsetOf
  • ShouldBeUnique
  • ShouldContain
    • T
    • Predicate<T>
  • ShouldNotContain
    • T
    • Predicate<T>

Dictionaries

  • ShouldContainKey
    • ShouldNotContainKey
  • ShouldContainKeyAndValue
    • ShouldNotContainValueForKey

Exceptions

  • Should.Throw
    • Action<T>
    • Func<T>
    • Task
    • ShouldThrow extension method
    • ShouldThrowAsync
  • ShouldNotThrow
    • Action<T>
    • Func<T>
    • Task
    • ShouldThrow extension method

Other

  • ShouldCompleteIn
  • ShouldSatisfyAllConditions
  • DynamicShould
    • HaveProperty
@josephwoodward
Copy link
Member

Sounds good! I'll try and make a start on some of these tonight.

@phil-scott-78
Copy link
Contributor

What are your thoughts about using a sample project to illustrate the code samples, and then bring in the code samples into the docs via Sphinx's literalinclude functionality?

You can see this in action on the ASP.NET docs

Source - https://raw.githubusercontent.com/aspnet/Docs/master/aspnet/tutorials/your-first-aspnet-application.rst
In Action - http://aspnet.readthedocs.org/en/latest/tutorials/your-first-aspnet-application.html

That way the samples more or less get compiled with the build (assuming the sample project is included in the build process, of course). Coding style and standards could also be easily enforced. Plus it'd give people a chance to open the project and run through all the examples. I figure people will probably be writing their sample code in Visual Studio regardless - this just saves them from having to create their own project for copying and pasting.

The downside is I don't think markdown supports this. I've always used reStructuredText with Sphinx myself, so I'm pretty comfortable with it but I could see it being a an initial blocker to people contributing.

@JakeGinnivan
Copy link
Contributor Author

Hey @enkafan

That sounds pretty cool actually. I don't mind switching to rst, I haven't used it myself but if you wanted to submit a PR which switches it I am happy to go down that road. I don't think it will be a blocker to contributing as there are examples to follow.

@phil-scott-78
Copy link
Contributor

Issued a pull request (#316) with a quick redo to Sphinx. I included a contributing page pulled from the ASP.NET groups contributing page to include steps on running sphinx on your local box plus the style guidelines they recommend.

@billglover
Copy link

Was about to jump in and try and help but it looks as though we need PR #316 to be merged before starting. It looks as though reStructuredText is now the preferred format.

@JakeGinnivan
Copy link
Contributor Author

@billglover merged now :) sorry about that

@JakeGinnivan
Copy link
Contributor Author

Hey all,

I have put some new docs infrastructure in place which makes all this quite nice. Help on finishing this off would be awesome :)

@josephwoodward
Copy link
Member

I've started working on this, however I'm noticing that my new assertions aren't appearing within the navigation of other assertion doc files (ie: _build/html/assertions/shouldMatchApproved.html). I've added the assertion to the index.rst file (I see you did the same thing when updating the docs); do you have any ideas what I could be missing?

@JakeGinnivan
Copy link
Contributor Author

Make sure you delete your local _build folder and rebuild. I have noticed it doesn't always rebuild the TOC

@josephwoodward
Copy link
Member

Alright, thanks Jake. I'll give that a try.

@josephwoodward
Copy link
Member

Finally got around to trying it and that was the issue, you've got to delete the _build folder and rebuild (for anyone else who experiences the same issue!)

@mwhitis
Copy link

mwhitis commented Jan 12, 2017

@JakeGinnivan - Is the list at the top of the issue still current for what needs converting? Been looking for a project to get involved with, and this seems like a good place to jump in.

@josephwoodward
Copy link
Member

Hi @mwhitis Yes, the list is still up to date. Help with the docs would be very much appreciated!

@morrme
Copy link

morrme commented Mar 26, 2017

i'm a little new, so pardon my question, but does this just involve taking a topic and reformatting it to fit the doc format of this repo?

@josephwoodward
Copy link
Member

Hi @morrme

Yes it does, though we have some means of auto generating the code samples. This pull request will give you an idea of what's involved.

If you have any questions then do ask :)

@morrme
Copy link

morrme commented Apr 21, 2017

@josephwoodward took me a while to find this issue again!

So are the generators written by hand based on the current samples?

@weav797
Copy link

weav797 commented Sep 10, 2018

Is this still an open issue? If so, I'd love to help out.

@josephwoodward
Copy link
Member

Yes it is still an issue, there's soooo much migration to do :S

@weav797
Copy link

weav797 commented Sep 26, 2018

Hey Joseph,

Sorry for the wait in responding. I'll try to set aside some time this weekend. It's been hectic at work. I'll let you know once I get set up and everything.

@weav797
Copy link

weav797 commented Oct 1, 2018

@josephwoodward I sent you an email regarding an issue. Can you see if you got it?

@TantumErgo
Copy link

I can see that this issue is still open, and that there's a ton left to do, but I honestly can't figure out what it is that needs to be done. I would like to help, so if anyone could explain to me what needs to be done, that would be great.

Is it just a matter of copying the content on the old docs site to the new docs site (readthedocs.org), or is there more involved?

@josephwoodward in an earlier comment, you referenced a pull request as being indicative of what this task involves, but I didn't understand even after taking a look at it...

@josephwoodward
Copy link
Member

Yeah, this is something I'd really like to finish soon. I'll need to refresh my memory on how to do it first, I also wonder whether there's a Docker container to help with setting up a local environment.

josephwoodward pushed a commit that referenced this issue Mar 21, 2020
* Fix (docs): Path to examples updated, correct lint errors in rst.  C# example changed as pyments appears to not like literal string parsing.

* task: Update Microsoft.Sourcelink.Github to v1

* Attempting to fix build error: Microsoft.Build.Tasks.Git.LocateRepository" task failed unexpectedly
@eddex
Copy link

eddex commented Sep 29, 2020

Yes it does, though we have some means of auto generating the code samples. This pull request will give you an idea of what's involved.

Hi, I just found this issue and I'm a bit confused. The changes referred to in the comment above refer to a commit where next to documentation also code changes were done. Is this issue only about migrating the documentation or is this some sort of a migration of the code too? And if so, where can we find the old codebase?

@SimonCropp
Copy link
Contributor

@jnm2 @josephwoodward ok i made a fair dint on the usages snippets and the resulting exception. see update list above. changes have been deployed to the docs site.

@josephwoodward
Copy link
Member

josephwoodward commented Oct 4, 2020

@jnm2 @josephwoodward ok i made a fair dint on the usages snippets and the resulting exception. see update list above. changes have been deployed to the docs site.

Oh nice! Thanks!

@SimonCropp
Copy link
Contributor

ok this is done. let me know if i missed anything

@jnm2
Copy link
Collaborator

jnm2 commented Oct 16, 2020

@SimonCropp You're a legend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests