Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copyFormatting doesn't have the agreed-upon default in the settings template #5403

Closed
DHowett-MSFT opened this issue Apr 17, 2020 · 1 comment · Fixed by #5404
Closed

copyFormatting doesn't have the agreed-upon default in the settings template #5403

DHowett-MSFT opened this issue Apr 17, 2020 · 1 comment · Fixed by #5404
Assignees
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree.
Milestone

Comments

@DHowett-MSFT
Copy link
Contributor

The spec for #5299 specified how we should handle the default for this setting.

@msftbot msftbot bot added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 17, 2020
@DHowett-MSFT DHowett-MSFT added Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. and removed Needs-Tag-Fix Doesn't match tag requirements labels Apr 17, 2020
@DHowett-MSFT DHowett-MSFT added this to the Terminal v1.0 milestone Apr 17, 2020
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 17, 2020
@msftbot msftbot bot added the In-PR This issue has a related PR label Apr 17, 2020
@msftbot msftbot bot closed this as completed in #5404 Apr 20, 2020
@msftbot msftbot bot removed the In-PR This issue has a related PR label Apr 20, 2020
msftbot bot pushed a commit that referenced this issue Apr 20, 2020
## Summary of the Pull Request
Added `copyFormatting` to defaults json files and userDefaults.

## PR Checklist
* [X] Closes #5403
@msftbot msftbot bot added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Apr 20, 2020
@msftbot
Copy link
Contributor

msftbot bot commented Apr 22, 2020

🎉This issue was addressed in #5404, which has now been successfully released as Windows Terminal Preview v0.11.1121.0.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants